Fix the release lane's member-count assertion before tagging v0.7.0 - #133
Merged
Conversation
The release lane asserted `4 bundles + 2 tools` and exited non-zero otherwise.
It has been `4 + 5` since v0.7.0: `motion_bvh` joined as a tool member, and
`ost` 0.22.2 widened tool discovery to reach
`adapters/<group>/<name>/tools/<tool>/`, which put `mocopi_record` and
`vmc_record` in the product without a descriptor in this repository changing.
Tagging v0.7.0 against the old assertion would have failed the lane at the
staging step, after every build and every packaging proof had passed.
So the expectation now comes from the tree: the staging step counts
`plugins/**/openstrata.plugin.yaml` and `{tools,adapters}/**/openstrata.tool.yaml`,
excluding the `.strata/` packaging copies of both, and requires the packager to
agree with them. A tool dropping out is still a failure -- the assertion is
still by member kind, so a bundle count that still adds up cannot mask it -- and
the next widening is now reported here rather than arriving in a published
archive. Measured locally: 4 declared bundles, 5 declared tools, and
`ost plugin package --workspace --product` producing exactly 4 + 5.
The header comment stops naming the two tools it used to name, and says why the
set is not a constant.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks the
v0.7.0tag. Found while preparing to tag #132, before pushinganything.
What would have happened
release.yml's staging step asserts the packaged member counts and exitsnon-zero otherwise:
It has been 4 + 5 since v0.7.0.
motion_bvhjoined as a tool member, andost0.22.2 widened tool discovery to reachadapters/<group>/<name>/tools/<tool>/, which putmocopi_recordandvmc_recordinto the product without a descriptor in this repository changing(ost report 35 §3).
Tagging against the old assertion would have failed the lane at the staging
step — after every build, both packaging runs and the digest-reproducibility
proof had already passed, on all three OS. This is the
hand-authored-
release.ymltrap exactly: a green PRlane proves nothing about it, because no PR event runs it.
The fix
The expectation comes from the tree instead of from a constant:
.strata/holds packaging copies of both descriptor kinds and must not becounted. The assertion stays by member kind, so a tool silently dropping out
still fails and cannot be masked by a bundle count that adds up — and the next
discovery widening is reported here rather than arriving in a published archive.
The header comment stops naming the two tools it used to name and says why the
set is not a constant.
Verification
ost plugin package --workspace --product: 4 bundles + 5 tools = 9 members,archives named
…-0.7.0-<target>.tar.zstpython -c "import yaml; yaml.safe_load(open('.github/workflows/release.yml'))"— parsesscripts/clean_install_smoke.py --skip-build— PASS against the 0.7.0 packagesworkflow_dispatchdry run of this branch — the real lane on realrunners, creating no release object. Result reported in a comment below.
One note for whoever reads the local logs
ost plugin test plugins/usdVrmaFileFormat --from-packagefails on thisworkstation with three empty-message failures at L3/L4/L5, which is an
0xC0000005inusdcat. It is stale local state, not a reader regression: thepackage stages its sibling libraries from
libs/<name>/build/<target>/, andthose trees here date to 2026-07-13 — six weeks and two releases before this
one — so a 0.7.0 plugin loads a July
vrmContainer.dll. The build tree passesthe same pyramid 12/12, and a fresh checkout has no such directory. The dry run
above is what settles it for CI.
🤖 Generated with Claude Code