fix: Escapes in raw text #29
Merged
Merged
Conversation
Prevents XSS by ensuring raw text within `<noscript>` elements is properly escaped during serialization if scripting is enabled. Adds a test to verify controlled payloads cannot break out of `<noscript>` and inject scripts. Fixes angular/angular#68903
Correct raw-text closing-tag escaping so astral Unicode characters cannot misalign the escaped `<` character. This prevents serialized raw-text content from breaking out into executable markup such as `</iframe><script>`.
SkyZeroZx
commented
May 25, 2026
| // (`[...rawText]`). Astral characters (e.g. emoji) before the match | ||
| // would otherwise shift the replacement and leave a real `</tag>` | ||
| // break-out in the output. | ||
| return rawText.replace( |
Author
There was a problem hiding this comment.
I was doing some regression testing and also found this issue with iframe and TextContent using astral characters like '😀', so we'll fix it in the same PR; it's added as another commit.
SkyZeroZx
changed the title
</noscript in raw text when scripting enabled
alan-agius4
reviewed
May 26, 2026
Author
|
@alan-agius4 Sorry for bothering. I think it would be worth mentioning this in the release notes for the latest Angular patches and, if applicable, generating an CVE/Advisor notice, since in SSR this could have been considered an XSS vector. |
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
May 29, 2026
Updates the domino dependency to the latest version as used in the main branch. This update contains fixes for angular/domino#29.
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
May 29, 2026
Updates the domino dependency to the latest version as used in the main branch. This update contains fixes for angular/domino#29.
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
May 29, 2026
Updates the domino dependency to the latest version as used in the main branch. This update contains fixes for angular/domino#29.
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
May 29, 2026
Updates the domino dependency to the latest version as used in the main branch. This update contains fixes for angular/domino#29.
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
May 29, 2026
Updates the domino dependency to the latest version as used in the main branch. This update contains fixes for angular/domino#29.
pkozlowski-opensource
pushed a commit
to angular/angular
that referenced
this pull request
May 29, 2026
Updates the domino dependency to the latest version as used in the main branch. This update contains fixes for angular/domino#29.
pkozlowski-opensource
pushed a commit
to angular/angular
that referenced
this pull request
May 29, 2026
Updates the domino dependency to the latest version as used in the main branch. This update contains fixes for angular/domino#29.
pkozlowski-opensource
pushed a commit
to angular/angular
that referenced
this pull request
May 29, 2026
Updates the domino dependency to the latest version as used in the main branch. This update contains fixes for angular/domino#29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Escapes </noscript in raw text when scripting enabled
Ensuring raw text within
<noscript>elements is properly escaped during serialization if scripting is enabled. Adds a test to verify controlled payloads cannot break out of<noscript>and inject scripts.Fixes angular/angular#68903
fix: fix raw-text element serialization
Correct raw-text closing-tag escaping so astral Unicode characters cannot
misalign the escaped
<character. This prevents serialized raw-text contentfrom breaking out into executable markup such as
</iframe><script>.