Skip to content

refactor(github-actions): move publish-ci logic to custom GHA action#3785

Merged
josephperrott merged 3 commits into
angular:mainfrom
josephperrott:task-3.3-robot-token-action
Jun 15, 2026
Merged

refactor(github-actions): move publish-ci logic to custom GHA action#3785
josephperrott merged 3 commits into
angular:mainfrom
josephperrott:task-3.3-robot-token-action

Conversation

@josephperrott

Copy link
Copy Markdown
Member

Moves PublishCiTool and its unit tests from ng-dev CLI to a new custom GitHub Action at github-actions/release/publish. The action handles token generation using the Angular Robot App key internally. Reusable workflow is updated to call this action.

Moves PublishCiTool and its unit tests from ng-dev CLI to a new custom GitHub Action at github-actions/release/publish. The action handles token generation using the Angular Robot App key internally. Reusable workflow is updated to call this action.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the publish-ci release publishing tool from a CLI command in ng-dev to a dedicated GitHub Action under github-actions/release/publish. It removes the publish-ci command from the ng-dev CLI, deletes the old CLI implementation, and introduces the new GitHub Action configuration, entry point, and Bazel build targets. Additionally, visibility rules in several ng-dev packages have been updated to support the new action. There are no review comments, and I have no further feedback to provide.

Adds the generated main.js to .prettierignore to prevent it from being formatted during commit, resolving the buildifier/prettier comparison test failure. Also adds missing dependencies (config, notes, versioning) to the test_lib target in BUILD.bazel.
Formats publish-ci.ts using prettier and regenerates the checked-in main.js bundle to match the formatted source.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 15, 2026
@josephperrott josephperrott merged commit 023fc8f into angular:main Jun 15, 2026
16 checks passed
@josephperrott

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants