Skip to content

Fix(nf): Re-enabled externals cache #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aukevanoost merged 3 commits into from
Nov 4, 2025
Merged

Fix(nf): Re-enabled externals cache #974

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dd9025
fix: Only bundle types if externals available
Aukevanoost Oct 26, 2025
1e2a52c
fix: Re-enabled externals cache
Aukevanoost Oct 26, 2025
1ac32d6
Merge branch 'angular-architects:main' into fix/performance-caching
Aukevanoost Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 77 additions & 55 deletions libs/native-federation-core/src/lib/core/build-for-federation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export const defaultBuildParams: BuildParams = {
skipShared: false,
};

let sharedPackageInfoCache: SharedInfo[] = [];
// Externals cache
const sharedPackageInfoCache: SharedInfo[] = [];
const cachedSharedPackages = new Set<string>();

export async function buildForFederation(
config: NormalizedFederationConfig,
Expand Down Expand Up @@ -56,64 +58,83 @@ export async function buildForFederation(
const { sharedBrowser, sharedServer, separateBrowser, separateServer } =
splitShared(config.shared);

let start = process.hrtime();
const sharedPackageInfoBrowser = await bundleShared(
sharedBrowser,
config,
fedOptions,
externals,
'browser'
);
logger.measure(
start,
'[build artifacts] - To bundle all shared browser externals'
);
if (Object.keys(sharedBrowser).length > 0) {
const start = process.hrtime();
const sharedPackageInfoBrowser = await bundleShared(
sharedBrowser,
config,
fedOptions,
externals,
'browser'
);

start = process.hrtime();
const sharedPackageInfoServer = await bundleShared(
sharedServer,
config,
fedOptions,
externals,
'node'
);
logger.measure(
start,
'[build artifacts] - To bundle all shared node externals'
);
logger.measure(
start,
'[build artifacts] - To bundle all shared browser externals'
);

start = process.hrtime();
const separatePackageInfoBrowser = await bundleSeparate(
separateBrowser,
externals,
config,
fedOptions,
'browser'
);
logger.measure(
start,
'[build artifacts] - To bundle all separate browser externals'
);
sharedPackageInfoCache.push(...sharedPackageInfoBrowser);
Object.keys(sharedBrowser).forEach((packageName) =>
cachedSharedPackages.add(packageName)
);
}

start = process.hrtime();
const separatePackageInfoServer = await bundleSeparate(
separateServer,
externals,
config,
fedOptions,
'node'
);
logger.measure(
start,
'[build artifacts] - To bundle all separate node externals'
);
if (Object.keys(sharedServer).length > 0) {
const start = process.hrtime();
const sharedPackageInfoServer = await bundleShared(
sharedServer,
config,
fedOptions,
externals,
'node'
);
logger.measure(
start,
'[build artifacts] - To bundle all shared node externals'
);
sharedPackageInfoCache.push(...sharedPackageInfoServer);
Object.keys(sharedServer).forEach((packageName) =>
cachedSharedPackages.add(packageName)
);
}

if (Object.keys(separateBrowser).length > 0) {
const start = process.hrtime();
const separatePackageInfoBrowser = await bundleSeparate(
separateBrowser,
externals,
config,
fedOptions,
'browser'
);
logger.measure(
start,
'[build artifacts] - To bundle all separate browser externals'
);
sharedPackageInfoCache.push(...separatePackageInfoBrowser);
Object.keys(separateBrowser).forEach((packageName) =>
cachedSharedPackages.add(packageName)
);
}

sharedPackageInfoCache = [
...sharedPackageInfoBrowser,
...sharedPackageInfoServer,
...separatePackageInfoBrowser,
...separatePackageInfoServer,
];
if (Object.keys(separateServer).length > 0) {
const start = process.hrtime();
const separatePackageInfoServer = await bundleSeparate(
separateServer,
externals,
config,
fedOptions,
'node'
);
logger.measure(
start,
'[build artifacts] - To bundle all separate node externals'
);
sharedPackageInfoCache.push(...separatePackageInfoServer);
Object.keys(separateServer).forEach((packageName) =>
cachedSharedPackages.add(packageName)
);
}
}

const sharedMappingInfo = !artefactInfo
Expand Down Expand Up @@ -189,6 +210,7 @@ function splitShared(
const separateServer: Record<string, NormalizedSharedConfig> = {};

for (const key in shared) {
if (cachedSharedPackages.has(key)) continue;
const obj = shared[key];
if (obj.platform === 'node' && obj.build === 'default') {
sharedServer[key] = obj;
Expand Down