Skip to content

feat(nf): forward serve port for native federation lib #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aukevanoost merged 2 commits into from
Oct 21, 2025
Merged

feat(nf): forward serve port for native federation lib #967

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f99acc6
feat(nf): forward serve port for native federation lib
JGhignatti Oct 16, 2025
683b24c
fix(nf): only forward serve port when serving
JGhignatti Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions libs/native-federation/src/builders/build/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,6 @@ export async function* runBuilder(
return;
}

let options = (await context.validateOptions(
targetOptions,
builder
)) as JsonObject & ApplicationBuilderOptions;

/**
* Explicitly defined as devServer or if the target contains "serve"
*/
Expand All @@ -130,6 +125,16 @@ export async function* runBuilder(
? !!nfOptions.devServer
: target.target.includes('serve');

let options = (await context.validateOptions(
runServer
Comment thread
Aukevanoost marked this conversation as resolved.
? {
...targetOptions,
port: nfOptions.port || targetOptions['port'],
}
: targetOptions,
builder
)) as JsonObject & ApplicationBuilderOptions;

let serverOptions = null;

const write = true;
Expand Down
Loading