Add Polylang-aware alt text generation - #50
Conversation
|
Thanks, but this PR looks like it was AI-generated, and something feels off about parts of the code. I've got mixed feelings about it - not sure if it's worth doing a detailed review here or if it'd be faster to just implement this myself. |
|
Thanks for the candid feedback. You are right: I used AI assistance here, and I should have caught that the implementation drifted from the contract you described in #11. You asked for frontend language detection plus a language parameter in the API; this PR instead introduced post-ID plumbing, backend inference, fallbacks, a filter, and an analyzer stub. That is over-scoped and creates review work without first agreeing on the design. I do not want to spend your review time on that, so I am closing this PR. No detailed review is needed. Thanks again for calling it out plainly. |
|
Quick correction: this wasn't really scope drift from #11 - passing a context post ID and resolving the locale server-side is a fine design. What I was reacting to was the linters being tricked into silence instead of the actual issues being fixed: the I implemented this myself in #51, filter-based so Polylang support doesn't live inside the core generator. |
Summary
Validation
composer format:checkcomposer lintcomposer analysepnpm run format:checkpnpm run lintpnpm run buildCloses #11