Fix IME Enter key submission - #459
Draft
zhouzhuozhzh-maker wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
keyCode === 229process-key fallback, which can occur aftercompositionendon macOS.Why
When a Chinese IME was used to enter English text, pressing Enter to confirm the pending input could also submit the message. WebKit can report
isComposingas false by the time React receives that keydown, so checkingisComposingalone is insufficient.Impact
IME confirmation now keeps the draft in the composer. A subsequent normal Enter still sends as expected.
Validation
npm test -- --run src/components/Composer.input.test.tsx src/components/Composer.skills.test.tsx(11 tests passed)npm run build