fix(providers): make Test probe chat completions, not just /models - #448
Open
HaoChiBao wants to merge 2 commits into
Open
fix(providers): make Test probe chat completions, not just /models#448HaoChiBao wants to merge 2 commits into
HaoChiBao wants to merge 2 commits into
Conversation
OpenAI-compatible verify can pass on a base missing /v1 if GET /models works; probing /chat/completions fails Test instead of hanging later turns.
Drop the extra helper and trim verify/test noise around the andrewyng#431 completions check.
|
go fuck yourself |
Contributor
Author
what I do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #431: provider Test only hit
GET /models, so a base URL missing/v1could look fine while real chat calls 404 and hang.OpenAI-compatible Test now also probes
POST /chat/completions. A 404 fails with a hint to add/v1.Test plan
pytest tests/test_provider_verify.py/v1fails Test; with/v1succeedsCloses #431