Repository navigation
Stop services when AppKit terminates the app on macOS - #21
Merged
Merged
Conversation
The app menu's Quit (and its Cmd-Q), the Dock's Quit, and logging out go through NSApplication terminate:, which exits the process from inside the event loop, so Desktop::run never reached its shutdown and managed services were left running. Stop the manager from an NSApplicationWillTerminateNotification observer as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quitting on macOS through AppKit — the app menu's Quit (and its Cmd-Q), the Dock's Quit, or logging out — left every managed service running.
These paths call
NSApplication terminate:, which exits the process from inside the event loop, soDesktop::runnever reached its shutdown. The manager is now also stopped from anNSApplicationWillTerminateNotificationobserver (a no-op on other platforms).Verified on macOS by sending
terminateto a running instance with asleepservice: before, the app exited with no shutdown logged andsleepwas orphaned under PID 1; after, the service is stopped with SIGTERM and nothing is left behind.ci/unix/ci.shpasses on Linux (including the e2e) and on macOS.Also bumps the version to 0.0.18.
🤖 Generated with Claude Code