Repository navigation
Edit the configuration while services run; restart only on a changed apply - #20
Merged
Merged
Conversation
…apply Edit Config opens the editor without stopping anything. Apply validates and saves it, then restarts the proxy and services only if the parsed configuration differs from the running one (comment and formatting edits do not count); while stopped the same button is Start All. Save no longer requires stopping. The read-only view and Stop All & Edit Config (with Ctrl+Shift+E) are gone, and the Routes tab lists the running configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cancel (Escape) discards unsaved edits and returns to the service list; it is shown only while running, since the editor is the only view while stopped. Ctrl+E now only opens the editor, and Ctrl+R no longer reloads it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cancel (Escape) always discards unsaved edits and returns to the service list, independent of the run state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dropping the first listener lets the OS hand the same port out again; the changed configuration would then match the running one and not restart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manager::apply()returnsStarted/Restarted/Unchanged;save_configno longer refuses while running (StillRunningremoved); Routes lists the running configuration.Tests
cargo fmt,cargo clippy --all-targets -- -D warnings,cargo test(73 passed)ci/unix/e2e.shpasses on the labwc session, with cancel, unchanged-apply and changed-apply steps🤖 Generated with Claude Code