Repository navigation
Use the fft-correlation crate for FFT cross-correlation (0.4.3) - #53
Merged
Merged
Conversation
The Rust rewrite inlined a copy of fft-correlation as dsp/correlate.rs. Drop the copy and depend on the crate again; the workspace/template caching that had been added here now lives there, together with FFT sizes of the form m * 2^k (m in 1, 3, 5, 9, 15) instead of the next power of two. Detections are unchanged on two hours of 8 kHz audio and runs with mixed clip lengths are about 12% faster. - Error gains a Correlation variant (RuntimeError in Python). - The dependency is an interim path reference to a sibling checkout of fft-correlation (0.0.6, unreleased). It does not resolve in CI and must become a git tag dependency once that version is tagged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the interim path reference to a sibling checkout with a git tag dependency, now that v0.0.6 is released, so the build resolves in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dsp/correlate.rs) that the Rust rewrite introduced and depend on thefft-correlationcrate again (git tagv0.0.6). The workspace/template caching that had been added here now lives in that crate.m * 2^k(min 1, 3, 5, 9, 15) covering the correlation instead of the next power of two, which doubled the FFT for clips longer than about 2.5 s at the default 60 s chunk.Errorgains aCorrelationvariant, raised asRuntimeErrorfrom the Python bindings.Testing
cargo clippy --all-targets -- -D warnings, also with thepythonfeaturecargo test --locked🤖 Generated with Claude Code