Repository navigation
Split into core library and CLI crates, release 0.4.1 - #51
Merged
Merged
Conversation
Turn the repo into a Cargo workspace: - crates/core: audio-pattern-detector-core (lib audio_pattern_detector_core) with the detector, audio I/O and the PyO3 bindings. No clap dependency. - crates/cli: audio-pattern-detector, the binary, depending on the core crate. The version is shared via [workspace.package]. pyproject.toml points maturin at the core crate and keeps the Python module name audio_pattern_detector. Integration tests moved with their crate and reference the repo-root sample_audios/ as ../../sample_audios/. The no-ffmpeg CLI test moved to the CLI crate since it needs the binary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns the repo into a Cargo workspace:
crates/core—audio-pattern-detector-core(libaudio_pattern_detector_core): detector, audio I/O, ffmpeg helper and the PyO3 bindings (pythonfeature). No clap dependency.crates/cli—audio-pattern-detector: theaudio-pattern-detectorbinary, depending on the core crate.Other changes:
[workspace.package], bumped to 0.4.1.pyproject.tomlsetsmanifest-path = "crates/core/Cargo.toml"andmodule-name = "audio_pattern_detector". The wheel layout is unchanged compared to main.sample_audios/as../../sample_audios/.... The test that runs the CLI with no ffmpeg onPATHmoved to the CLI crate.-p audio-pattern-detector-core.Verified locally:
cargo clippy --all-targets -- -D warnings,cargo test(287 passed),maturin buildand the Python binding tests against the built wheel.🤖 Generated with Claude Code