Repository navigation
refactor(core): remove dependency on @cloudflare/workers-types - #450
Merged
Merged
Conversation
Replace the ambient Workers types with small structural types (CaDatabase, CaSecret) and Hono's ExecutionContext so the published declarations no longer require @cloudflare/workers-types. Wrangler-generated bindings still satisfy SshCaBindings directly. Keep Workers as the primary target by asserting in workers-integration that the package satisfies ExportedHandler<Env> and that Env is assignable to SshCaBindings, with a type check now run as part of test:workers. Also add @types/node as an explicit dev dependency, set lib explicitly in tsconfig, and drop the unused CFArgs type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 71.32% 71.32%
=======================================
Files 20 20
Lines 1123 1123
Branches 266 266
=======================================
Hits 801 801
Misses 297 297
Partials 25 25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Make clear that the package targets and is tested on Cloudflare Workers while not relying on Workers-specific APIs, and list what it needs from the runtime and its bindings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.