feat(logos): update gb game logos - #926
Conversation
andrewbenington
left a comment
There was a problem hiding this comment.
Just a small nitpick, those constants are already in an enum.
Also, could you leave the box art images as, for example, Crystal-Box.png? I want to add the option to use box art down the line because I like how that looks
|
Also I just invited you as a repository collaborator, sorry that took so long |
Thank you. I was looking for that.
I was thinking that too. I will be fixing up the PR in just a moment. |
ed2815e to
7d9b4a1
Compare
|
All changes have been implemented. |
andrewbenington
left a comment
There was a problem hiding this comment.
looks great! sorry for the delay
7d9b4a1 to
d3db89b
Compare
Description
This PR updates most of the Pokémon Game Boy box art images to use logo images instead, bringing them in line with the style used for the Generation III and later games. I reconstructed these logos to closely match those found on the original box art, with green version being a custom logo.
BlueGreen and BlueJpn will continue to display box art images for now because of how those save files are currently identified. Separate logos for Blue Version and Green Version are available and can be used once a reliable method is established for determining whether a save belongs to Blue or Green Version.
Issue
None