Improve String-to-Number Conversion Logic in Seed Handling - #76
Open
allquantor wants to merge 1 commit into
Open
Improve String-to-Number Conversion Logic in Seed Handling#76allquantor wants to merge 1 commit into
allquantor wants to merge 1 commit into
Conversation
|
@andreasonny83 Thanks |
Owner
|
@alekmeckaroski |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces an optimized and potentially more collision-resistant string-to-number conversion method in the seed-handling logic.
Before:
With the current logic, different string seeds might result in the same numeric seed if the sum of their character codes is the same. For example:
"AB" would be converted to 138 because 'A' has a character code of 65, ' B' has a character code of 66, and 65 + 66 + 1 (the initial accumulator value) is 132.
"BA" would also be converted to 132 for the same reason.
Example:
Now:
A straightforward improvement to the hashing function enhances its capacity to disperse different input strings to a broader range of output values, thus reducing collisions.