and-oli · ravelinx22 · May 22, 2018
diff --git a/frontend/build/index.html b/frontend/build/index.html
@@ -1 +1,2 @@
-<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"><meta name="theme-color" content="#000000"><link rel="manifest" href="/manifest.json"><link rel="shortcut icon" href="/favicon.ico"><link href="https://stackpath.bootstrapcdn.com/bootstrap/4.1.1/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-WskhaSGFgHYWDcbwN70/dfYBj47jz9qbsMId/iRN3ewGhXQFZCSftd1LZCfmhktB" crossorigin="anonymous"><title>HeartBit</title><link href="/static/css/main.a6c64388.css" rel="stylesheet"></head><body><div id="root"></div><noscript>You need to enable JavaScript to run this app.</noscript><script type="text/javascript"></script><script type="text/javascript" src="/static/js/main.e714d604.js"></script></body></html>
+<!-- Se podrian poner mas metas -->
+<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"><meta name="theme-color" content="#000000"><link rel="manifest" href="/manifest.json"><link rel="shortcut icon" href="/favicon.ico"><link href="https://stackpath.bootstrapcdn.com/bootstrap/4.1.1/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-WskhaSGFgHYWDcbwN70/dfYBj47jz9qbsMId/iRN3ewGhXQFZCSftd1LZCfmhktB" crossorigin="anonymous"><title>HeartBit</title><link href="/static/css/main.a6c64388.css" rel="stylesheet"></head><body><div id="root"></div><noscript>You need to enable JavaScript to run this app.</noscript><script type="text/javascript"></script><script type="text/javascript" src="/static/js/main.e714d604.js"></script></body></html>
diff --git a/frontend/build/static/css/main.a6c64388.css.map b/frontend/build/static/css/main.a6c64388.css.map
diff --git a/frontend/build/static/js/main.e714d604.js b/frontend/build/static/js/main.e714d604.js
diff --git a/frontend/build/testResults.json b/frontend/build/testResults.json
diff --git a/frontend/build/usersData.json b/frontend/build/usersData.json
diff --git a/frontend/src/App.js b/frontend/src/App.js
@@ -13,6 +13,8 @@ class App extends Component {
       twitterUses : []
     }
   }
+
+	// Seria bueno desacoplar las responsabilidades de esta funcion
   componentDidMount(){
     fetch("https://www.instagram.com/explore/tags/hypertension/?__a=1").then((response) => response.json())
     .then((responseJson) => {

diff --git a/frontend/src/Community.js b/frontend/src/Community.js
@@ -15,6 +15,7 @@ class Community  extends Component {
   }
   componentDidMount(){
   }
+	// Seria bueno utilizar una misma convencion para las funciones unas tienen son arrow functions otras no
   showInputCard=()=>{
     return(
       <div className = "col-sm-12 " >

diff --git a/frontend/src/Map.js b/frontend/src/Map.js
@@ -38,6 +38,7 @@ class Map extends Component {
       this.paintMap();
     }
   }
+	// Seria bueno utilizar patron de reusabilidad de graficas
   paintMap = ()=>{
     var width = 400;
     var height = 500;

diff --git a/frontend/src/MapInfo.js b/frontend/src/MapInfo.js
@@ -7,6 +7,7 @@ class MapInfo  extends Component {
     this.state = {
     };
   }
+	// Seria bueno reutilizar patron reusabilidad de graficas.
   paintGraph = ()=>{
 
     if(this.props.currentDepartment.name !== "Click on a department"){

diff --git a/frontend/src/index.css b/frontend/src/index.css
@@ -1,3 +1,5 @@
+
+/* Si solo se va a tener esta pequeña cantidad de css seria mejor ponerlo en los otros archivos css */
 body {
   margin: 0;
   padding: 0;

diff --git a/functions/index.js b/functions/index.js
@@ -43,7 +43,7 @@ app.use(function(req, res, next) {
 });
 
 
-
+// Seria bueno separar las rutas en otro archivo
 router.post("/authenticate",function(req,res){
   headUserRef.once("value").then((snap)=>snap.val()).then((json)=>{
     let user = req.body;
@@ -135,6 +135,8 @@ router.get("/mapInfo", function(req, res, next) {
     console.error(err);
   });
 });
+
+// Seria bueno separar los helpers de los routes o por lo menos ponerlo despues.
 multipartToJson = (req, res) => {
     if (req.method === 'POST') {
         const busboy = new Busboy({ headers: req.headers });