ci: namespace PR trigger and outcome labels with test: and ci: prefixes#399
ci: namespace PR trigger and outcome labels with test: and ci: prefixes#399shahan-khatchadourian-anchorage wants to merge 5 commits into
Conversation
Renames fuzz→test:fuzz, proptest→test:proptest, surfpool→test:surfpool, stagex→ci:stagex in workflow if-conditions to align with the chain: label convention already in use. GitHub label renames are a manual follow-up step. Closes #398 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Renames fuzz-failure→test:fuzz-failure, proptest-failure→test:proptest-failure, surfpool-failure→test:surfpool-failure to match the test: trigger label prefix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates label-gated GitHub Actions workflows to use namespaced PR labels (test:* for test triggers/outcomes and ci:* for build pipeline triggers), aligning CI label naming with the existing prefix conventions in the repo.
Changes:
- Updated
fuzzandproptestworkflow label gates totest:fuzz/test:proptestand failure labels totest:* -failure. - Updated the surfpool workflow’s trigger label to
test:surfpooland its failure label totest:surfpool-failure. - Updated the stagex workflow’s PR label gate from
stagextoci:stagex.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/fuzz-solana.yml |
Switches the gating label and failure label to test:fuzz / test:fuzz-failure. |
.github/workflows/proptest-solana.yml |
Switches the gating label and failure label to test:proptest / test:proptest-failure. |
.github/workflows/surfpool-solana.yml |
Switches the gating label and failure label to test:surfpool / test:surfpool-failure (including labeled-event guard). |
.github/workflows/stagex.yml |
Switches the PR label gate from stagex to ci:stagex. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Label PR on fuzz failure | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| PR_NUMBER: ${{ github.event.pull_request.number }} | ||
| run: | | ||
| if [ "${{ steps.fuzz_transaction_string.outcome }}" = "failure" ] || [ "${{ steps.fuzz_versioned_transaction.outcome }}" = "failure" ]; then | ||
| gh pr edit "$PR_NUMBER" --add-label fuzz-failure || true | ||
| gh pr edit "$PR_NUMBER" --add-label test:fuzz-failure || true | ||
| else | ||
| gh pr edit "$PR_NUMBER" --remove-label fuzz-failure || true | ||
| gh pr edit "$PR_NUMBER" --remove-label test:fuzz-failure || true |
There was a problem hiding this comment.
Good catch — updated docs/contributor-guides/testing-visualizations.mdx in ed2a2d2: the CI workflow table now uses test:proptest / test:fuzz and the failure-label note uses test:proptest-failure / test:fuzz-failure. Also corrected the stale workflow filenames (proptest.yml -> proptest-solana.yml, fuzz.yml -> fuzz-solana.yml). The ci label row is unchanged since this PR didn't rename it.
There was a problem hiding this comment.
Followed up in 776d227 to make the table fully current: added rows for the other two renamed labels — test:surfpool (surfpool-solana.yml) and ci:stagex (stagex.yml) — a one-line note on the test: vs ci: prefix convention, and test:surfpool-failure in the outcome-label paragraph. All label names and workflow filenames now match the .github/workflows/ files on this branch.
There was a problem hiding this comment.
Followed up in 776d227 to make the table fully current: added rows for the other two renamed labels — test:surfpool (surfpool-solana.yml) and ci:stagex (stagex.yml) — a one-line note on the test: vs ci: prefix convention, and test:surfpool-failure in the outcome-label paragraph. All label names and workflow filenames now match the .github/workflows/ files on this branch.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Summary
Renames the four label-gated CI workflow triggers and their outcome labels to align with the
chain:prefix convention already in use.fuzztest:fuzzproptesttest:proptestsurfpooltest:surfpoolstagexci:stagexfuzz-failuretest:fuzz-failureproptest-failuretest:proptest-failuresurfpool-failuretest:surfpool-failuretest:groups labels that gate test runs;ci:covers the build/image pipeline.Manual steps required after merge
test:surfpoolon open PRs currently carryingsurfpool(at minimum fix(solana_test_utils): SurfpoolManager::airdrop returns Ok on confirmed-but-failed transactions #291, test(surfpool): tighten surfpool roundtrip — surfpool is started but never queried #290)Closes #398
🤖 Generated with Claude Code