Skip to content

feat: Add modular dashboard with TemplUI components - #3

Open
Parvaggarwal01 wants to merge 5 commits into
ananyatimalsina:mainfrom
Parvaggarwal01:main
Open

feat: Add modular dashboard with TemplUI components#3
Parvaggarwal01 wants to merge 5 commits into
ananyatimalsina:mainfrom
Parvaggarwal01:main

Conversation

@Parvaggarwal01

Copy link
Copy Markdown

Add comprehensive dashboard with TemplUI components, local card component, and responsive layout.

@ananyatimalsina

Copy link
Copy Markdown
Owner

This is good to see. However there are some issues with the commit as is:

  • Please refrain from including unrelated files with your PR (.env in this case)
  • The Dashboard page is too modular in places where it doesn't make any sense to be. The components that are used only once should directly go into the main component.

@Parvaggarwal01

Copy link
Copy Markdown
Author

Fixed over-modularization:

  • Refactored the dashboard to inline single-use components directly into the main Dashboard template

  • Removed unnecessary abstractions like DashboardHeader(), StatsGrid(), ActiveEventsSection(), etc.

@ananyatimalsina

Copy link
Copy Markdown
Owner

The Recent Activity seems to be bugged. As well as that, the table for Active Voting Events is inconsistent when compared the the modemnagement one. Also you might consider redirecting to the Events page when clicking New Event, though I am still unsure about that being the default action, as a regular User probably wouldn't interact with creating Events nearly enough to justify if being there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants