Skip to content

feat: DirectorNotes and director_cues - #64

Merged
sebvanleuven merged 4 commits into
mainfrom
feat/director_notes
Jul 8, 2026
Merged

feat: DirectorNotes and director_cues#64
sebvanleuven merged 4 commits into
mainfrom
feat/director_notes

Conversation

@sebvanleuven

@sebvanleuven sebvanleuven commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Add DirectorNotes to PersonaConfig for session-wide director notes defaults at session-start, and Session.send_director_note_cue() to send turn-scoped director-note cues over the data channel. at_seconds/in_seconds are validated as finite client-side (non-finite values would serialize to invalid JSON). All other invalid cue semantics will log a warning and be ignored. Includes unit tests and README documentation.


Summary by cubic

Adds Director Notes to control avatar delivery style. Set session defaults with PersonaConfig(director_notes=...) and send turn-scoped cues with Session.send_director_note_cue(...); timing args must be finite and sends wait for the data channel.

  • New Features

    • DirectorNotes dataclass and PersonaConfig(director_notes=...) for session-start defaults (e.g., preset_style, expressivity, custom_style_prompt); expressivity validated as finite.
    • Session.send_director_note_cue(tag, at_seconds?, in_seconds?) to send runtime cues over the data channel; rejects non-finite timing values and raises on send failure.
    • DirectorNotes exported from anam; README adds usage examples and validation notes.
  • Refactors

    • Centralized data-channel readiness in _ensure_data_channel_open() and used it in send_message and interrupt for reliable sends.

Written for commit 8940f48. Summary will update on new commits.

Review in cubic

…ession-defaults, and Session.send_director_note_cue() to send turn-scoped director-note cues

over the data channel. at_seconds/in_seconds are validated as finite client-side (non-finite values would serialize to invalid JSON). All other invalid cue semantics will log a warning and be ignored. Includes unit tests and README documentation
@sebvanleuven
sebvanleuven requested review from ao-anam and sr-anam July 7, 2026 17:51

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread README.md Outdated
@sebvanleuven
sebvanleuven requested a review from bc-anam July 8, 2026 10:23
Comment thread src/anam/types.py Outdated
Comment thread src/anam/types.py Outdated
Comment thread src/anam/client.py Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Comment thread src/anam/client.py Outdated
@sebvanleuven
sebvanleuven merged commit e49ef36 into main Jul 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants