Skip to content

Chore: align enable_audio_passthrough with JS SDK - #30

Merged
sebvanleuven merged 5 commits into
mainfrom
fix/default_enable_audio_passthrough
Feb 10, 2026
Merged

Chore: align enable_audio_passthrough with JS SDK#30
sebvanleuven merged 5 commits into
mainfrom
fix/default_enable_audio_passthrough

Conversation

@sebvanleuven

@sebvanleuven sebvanleuven commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

The default (in case of unset) bypasses all of Anam's orchestration layer. Switch default behaviour


Summary by cubic

Set PersonaConfig.enable_audio_passthrough default to False to match the JS SDK and prevent unintended orchestration bypass. Clarified the docstring (removed the incorrect ephemeral-persona note), updated tests, and cleaned up a stray debug line.

  • Migration
    • If you need audio passthrough, explicitly set enable_audio_passthrough=True in PersonaConfig.

Written for commit 6615f01. Summary will update on new commits.

@sebvanleuven
sebvanleuven requested a review from ao-anam February 9, 2026 15:17

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@sebvanleuven sebvanleuven changed the title Aligning enable_audio_passthrough with JS SDK Chore: align enable_audio_passthrough with JS SDK Feb 10, 2026
@sebvanleuven
sebvanleuven requested a review from bnogas February 10, 2026 14:14
Comment thread tests/test_client.py Outdated
@sebvanleuven
sebvanleuven removed the request for review from bnogas February 10, 2026 23:45
@sebvanleuven
sebvanleuven merged commit bbad901 into main Feb 10, 2026
8 checks passed
@sebvanleuven
sebvanleuven deleted the fix/default_enable_audio_passthrough branch February 11, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants