Get rid of platdata from adi spi3 - #94
Conversation
8501f71 to
af11601
Compare
vasbimpikasadi
left a comment
vasbimpikasadi
left a comment
There was a problem hiding this comment.
clean refactor and ~30 lines unneeded lines removed. Ship it!
pamolloy
left a comment
pamolloy
left a comment
There was a problem hiding this comment.
@jiez Once you address Ozan's comment and the following please submit it upstream.
Minor inaccuracy: The commit message states that fields were "immediately copied into adi_spi_priv during probe()" in the old code. In reality, max_hz was NOT copied to priv—it remained in platdata and was accessed directly from there. However, this doesn't affect the correctness of the code change itself.
Claude Sonnet 4.6
adi_spi_platdata is an unnecessary indirection. Read all DT properties directly into priv in probe(). Signed-off-by: Jie Zhang <jie.zhang@analog.com>
af11601 to
164774d
Compare
Funny thing is this commit message was generated by Claude. I just removed the inaccurate part. |
5 participants
A recent discussion with Caleb let me realize that adi_spi_platdata is an unnecessary indirection. Removing it will simplify the driver code.