ci/build: fail the job on hard check errors - #137
Open
ozan956 wants to merge 1 commit into
Open
Conversation
check_checkpatch, check_license and check_qconfig_sync detect hard errors by setting fail=1 and returning it, but the downstream summary only fails on step_fail_<name> variables in GITHUB_ENV, which are written by the ERR trap. A bare 'return 1' does not trigger the trap, so the error was annotated and the step exited non-zero, yet the job (continue-on-error: true) and the aggregated result stayed green. A commit missing a Signed-off-by line, for example, passed CI. Set step_fail_<name> explicitly when fail=1 so the failure is recorded and the aggregated check fails. Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
Member
Author
|
And we also need something like that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare
return 1does not trigger the trap, so the error was annotated and the step exited non-zero, yet the job (continue-on-error: true) and the aggregated result stayed ok.A commit missing a Signed-off-by line, for example, passed CI. https://github.com/analogdevicesinc/u-boot/actions/runs/30635738326/job/91172768680?pr=136#step:8:39
Not tested whether this triggers or not, not on the corp net rn. @gastmaier