Align ADSP SC5XX gptimer DTS and driver with Linux - #106
Open
jiez wants to merge 1 commit into
Open
Conversation
Replace the flat adi,sc5xx-gptimer node (two reg entries pointing directly at group and per-timer registers) with the hierarchical adi,sc5xx-gptimers binding used by Linux: a parent gptimers node with a single reg covering the full block, and a gptimer@0 child identified by adi,offset and adi,is-clocksource. Update the timer driver to probe the parent node, iterate child ofnodes to find the clocksource, and compute register addresses from the parent base plus adi,offset. Drop the struct-based register access in favour of explicit offset defines matching the Linux driver. Signed-off-by: Jie Zhang <jie.zhang@analog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the flat adi,sc5xx-gptimer node (two reg entries pointing directly at group and per-timer registers) with the hierarchical adi,sc5xx-gptimers binding used by Linux: a parent gptimers node with a single reg covering the full block, and a gptimer@0 child identified by adi,offset and adi,is-clocksource.
Update the timer driver to probe the parent node, iterate child ofnodes to find the clocksource, and compute register addresses from the parent base plus adi,offset. Drop the struct-based register access in favour of explicit offset defines matching the Linux driver.