ad9213 dev pyadi by TudorAndreiTicudean · Pull Request #770 · analogdevicesinc/pyadi-iio

TudorAndreiTicudean · 2026-06-23T12:52:46Z

Description

Add PyADI support for ad9213 based on already-existing: https://github.com/analogdevicesinc/pyadi-iio/tree/ad9213_dev

Fixes # (issue)

Type of change

How has this been tested?

State explicitly whether this was tested against real hardware, an emulated context (iio-emu), or not run. Name the part(s) and the context URI or board used.

Hardware / emulation: Real hardware - AD9213 on VCU118. Also verified against emulated context via iio-emu with ad9213.xml.
Commands run (e.g. python3 -m pytest -k ad4080 --adi-hw-map):
-- pytest test/test_ad9213.py -v
-- python3 examples/ad9213_example.py
Result: Test passed. Example ran successfully, register read/write and RX buffer capture confirmed working.

Test configuration

Kernel / libiio version: 6.12.0-26956-g8edd67c2e728 / libiio 0.25
OS: Linux buildroot (target), WSL2 Ubuntu (host)
FPGA carrier (if applicable): VCU118

Documentation

No documentation change needed
Updated existing docs under doc/source/
Added a new device page and linked it from the relevant toctree

New device class interfaces

Skip this section if the PR does not add a new device class.

Class extends one of the common base classes in adi.device_base (rx_chan_comp, tx_chan_comp, or a _no_buff variant). If not, explain why in the description. See the Device Base Classes developer doc page.
compatible_parts lists every part number this class supports
Part numbers added to supported_parts.md (verify with invoke checkparts)
Emulation context (xml_gen, not iio_genxml) added under test/emu/ and referenced from a test
Tests added that run against the emulation context in CI

Checklist

invoke precommit passes locally
All commits are signed off (Signed-off-by: Name <email>)
No new warnings from the build or doc generation
Dependent changes in libiio, kernel, or HDL are merged and referenced

Signed-off-by: PopPaul2021 <Paul.Pop@analog.com>

Finished adding pyadi-iio support for ad9213. The branch was created based on: https://github.com/analogdevicesinc/pyadi-iio/tree/ad9213_dev Signed-off-by: Tudor-andrei-Ticudean_adi <Tudor-andrei.Ticudean@analog.com>

Keep validated ad9213 driver implementation based on real hardware (iio_info from VCU118 + AD9213). Main had an unvalidated stub using rx_def and axi-ad9213-rx-hpc which does not exist on actual hardware. Signed-off-by: Tudor-andrei-Ticudean <Tudor-andrei.Ticudean@analog.com>

github-actions · 2026-06-23T13:09:57Z

Test Results

2 047 tests +1 754 ✅ ±0 4m 14s ⏱️ -8s
1 suites ±0 1 293 💤 +1
1 files ±0 0 ❌ ±0

Results for commit 3e2b354. ± Comparison against base commit 696c4b0.

♻️ This comment has been updated with latest results.

github-actions · 2026-06-25T10:21:06Z

IIO Context Coverage Report

New device classes in this PR: (adis16375, adis16480, adis16485, adis16488

Minimum required total coverage: 75.0%

Summary

Hardware	Device Attr Coverage	Channel Attr Coverage	Total Coverage	Status
adis16480	0/4 (0.0%)	0/49 (0.0%)	0/53 (0.0%)	❌

Untested attributes (click to expand)

adis16480

adis16480 device attrs untested: current_timestamp_clock, sampling_frequency
null device attrs untested: add_trigger, remove_trigger
adis16480 input ch accel_x untested: calibbias, calibscale, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch accel_y untested: calibbias, calibscale, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch accel_z untested: calibbias, calibscale, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch anglvel_x untested: calibbias, calibscale, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch anglvel_y untested: calibbias, calibscale, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch anglvel_z untested: calibbias, calibscale, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch magn_x untested: calibbias, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch magn_y untested: calibbias, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch magn_z untested: calibbias, filter_low_pass_3db_frequency, raw, scale
adis16480 input ch pressure0 untested: calibbias, raw, scale
adis16480 input ch temp0 untested: offset, raw, scale
rpi_volt input ch in0 untested: lcrit_alarm

❌ Coverage check failed. The following new parts are below the 75.0% minimum total coverage: adis16480.

Generated by IIO Context Coverage workflow

github-actions · 2026-06-25T10:45:38Z

Generated documentation for this PR is available at Link

Signed-off-by: Tudor-andrei-Ticudean <Tudor-andrei.Ticudean@analog.com>

tfcollins · 2026-07-01T17:11:50Z

The driver naming here of ad9213 is non-standard. We always use a convention axi-<part>-rx-hpc. I guess this is a devicetree naming bug?

tfcollins

The driver naming seems off. Please consult with the Linux team here.

TudorAndreiTicudean · 2026-07-06T10:16:16Z

The driver naming here of ad9213 is non-standard. We always use a convention axi-<part>-rx-hpc. I guess this is a devicetree naming bug?

Checked the ADI Linux dev branch ad9213_check, in drivers/iio/adc/ad9213.c the device name is hardcoded as "ad9213" (line 692) and the DT compatible is "adi,ad9213". Note this branch is still in development and not yet upstream. I think this might follow the SPI device convention rather than the AXI core axi--rx-hpc naming, but I'm not sure, happy to update if needed or ask the Linux team.

Update: I asked the person that created the PR about the naming. From what I understand it should be parsed from device tree and not hardcoded.

Update 2: Person answered: The ad9213 does not use "axi_adc", it uses "iio_backend" so the naming should be correct in this case. Maybe it could be named to "ad9213_phy" to be more precise.

tfcollins

Can to address the inheritance usage question of rx vs rx_def

tfcollins · 2026-07-01T17:14:13Z


 from adi.context_manager import context_manager
-from adi.rx_tx import rx_def
+from adi.rx_tx import rx


Keep rx_def. It has more supported features

tfcollins · 2026-07-01T17:14:43Z

+        """sampling_frequency: Sample rate of the ADC in Hz."""
+        return self._get_iio_attr("voltage0", "sampling_frequency", False, self._rxadc)
+
+    def ad9213_register_read(self, reg):


this should be called just register_read. We already know its a ad9213

tfcollins · 2026-07-15T14:42:15Z


-class ad9213(rx_def, context_manager):
-    """ AD9213 High-Speed ADC """
+class ad9213(rx, context_manager):


Why are you using the rx class directly here vs the rx_def? rx_def would give you more functionality.

Signed-off-by: Tudor-andrei-Ticudean <Tudor-andrei.Ticudean@analog.com>

PopPaul2021 and others added 2 commits May 10, 2024 13:59

Add support for AD9213

e98ac69

Signed-off-by: PopPaul2021 <Paul.Pop@analog.com>

pyadi-iio: Add support for ad9213

2d3b650

Finished adding pyadi-iio support for ad9213. The branch was created based on: https://github.com/analogdevicesinc/pyadi-iio/tree/ad9213_dev Signed-off-by: Tudor-andrei-Ticudean_adi <Tudor-andrei.Ticudean@analog.com>

TudorAndreiTicudean had a problem deploying to internal-pr June 23, 2026 12:52 — with GitHub Actions Failure

TudorAndreiTicudean temporarily deployed to internal-pr June 23, 2026 13:03 — with GitHub Actions Inactive

TudorAndreiTicudean temporarily deployed to internal-pr June 25, 2026 10:07 — with GitHub Actions Inactive

TudorAndreiTicudean had a problem deploying to internal-pr June 25, 2026 10:07 — with GitHub Actions Failure

TudorAndreiTicudean temporarily deployed to internal-pr June 25, 2026 10:12 — with GitHub Actions Inactive

TudorAndreiTicudean had a problem deploying to internal-pr June 25, 2026 10:12 — with GitHub Actions Failure

TudorAndreiTicudean temporarily deployed to internal-pr June 25, 2026 10:40 — with GitHub Actions Inactive

TudorAndreiTicudean force-pushed the ad9213_dev_pyadi branch from a988269 to 9701afc Compare June 25, 2026 11:02

TudorAndreiTicudean temporarily deployed to internal-pr June 25, 2026 11:02 — with GitHub Actions Inactive

TudorAndreiTicudean force-pushed the ad9213_dev_pyadi branch from 9701afc to a988269 Compare June 25, 2026 11:13

TudorAndreiTicudean temporarily deployed to internal-pr June 25, 2026 11:13 — with GitHub Actions Inactive

pyadi-iio: Style and isort fixes

28b848b

Signed-off-by: Tudor-andrei-Ticudean <Tudor-andrei.Ticudean@analog.com>

TudorAndreiTicudean force-pushed the ad9213_dev_pyadi branch from a988269 to 28b848b Compare June 25, 2026 11:25

TudorAndreiTicudean temporarily deployed to internal-pr June 25, 2026 11:25 — with GitHub Actions Inactive

tfcollins self-requested a review July 1, 2026 17:12

tfcollins reviewed Jul 1, 2026

View reviewed changes

TudorAndreiTicudean requested a review from tfcollins July 6, 2026 10:18

tfcollins reviewed Jul 15, 2026

View reviewed changes

pyadi-iio: Use rx_def + fix naming

3e2b354

Signed-off-by: Tudor-andrei-Ticudean <Tudor-andrei.Ticudean@analog.com>

TudorAndreiTicudean temporarily deployed to internal-pr July 28, 2026 12:52 — with GitHub Actions Inactive

Navigation Menu

Uh oh!

ad9213 dev pyadi - #770

ad9213 dev pyadi#770
TudorAndreiTicudean wants to merge 5 commits into
mainfrom
ad9213_dev_pyadi

TudorAndreiTicudean commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 25, 2026

adis16480

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

tfcollins commented Jul 1, 2026

Uh oh!

tfcollins left a comment

Uh oh!

TudorAndreiTicudean commented Jul 6, 2026 •

edited

Loading

Uh oh!

tfcollins left a comment

Uh oh!

tfcollins Jul 1, 2026

Uh oh!

tfcollins Jul 1, 2026

Uh oh!

tfcollins Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

TudorAndreiTicudean commented Jun 23, 2026

Description

Type of change

How has this been tested?

Documentation

New device class interfaces

Checklist

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Jun 25, 2026

IIO Context Coverage Report

Summary

adis16480

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

tfcollins commented Jul 1, 2026

Uh oh!

tfcollins left a comment

Choose a reason for hiding this comment

Uh oh!

TudorAndreiTicudean commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tfcollins left a comment

Choose a reason for hiding this comment

Uh oh!

tfcollins Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

tfcollins Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

tfcollins Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 23, 2026 •

edited

Loading

TudorAndreiTicudean commented Jul 6, 2026 •

edited

Loading