Ad7124 6.12 update - #768
Open
thorenscientific wants to merge 1 commit into
Open
Conversation
thorenscientific
had a problem deploying
to
external-pr
June 20, 2026 14:19 — with
GitHub Actions
Failure
thorenscientific
force-pushed
the
ad7124_6.12_update
branch
from
July 14, 2026 21:45
28d5288 to
d107b66
Compare
thorenscientific
requested a deployment
to
external-pr
July 14, 2026 21:45 — with
GitHub Actions
Waiting
thorenscientific
force-pushed
the
ad7124_6.12_update
branch
from
July 14, 2026 21:50
d107b66 to
090cf35
Compare
thorenscientific
requested a deployment
to
external-pr
July 14, 2026 21:50 — with
GitHub Actions
Waiting
thorenscientific
marked this pull request as ready for review
July 14, 2026 21:59
|
|
||
| def _add_channel_instances(self): | ||
| """Initiate channel objects for each channel in the device.""" | ||
| if ( |
Contributor
Author
There was a problem hiding this comment.
@tfcollins for the record I did not check the case where self._channel_def IS defined.
tfcollins
force-pushed
the
ad7124_6.12_update
branch
from
July 15, 2026 21:19
090cf35 to
e654631
Compare
tfcollins
force-pushed
the
ad7124_6.12_update
branch
from
July 15, 2026 21:33
e654631 to
8d3a393
Compare
tfcollins
force-pushed
the
ad7124_6.12_update
branch
from
July 15, 2026 21:44
8d3a393 to
e9d6ff2
Compare
tfcollins
force-pushed
the
ad7124_6.12_update
branch
from
July 15, 2026 21:52
e9d6ff2 to
243a645
Compare
tfcollins
force-pushed
the
ad7124_6.12_update
branch
from
July 16, 2026 00:02
243a645 to
5bb7e1a
Compare
Update AD7124, CN0554, examples, documentation, emulation context, and tests for the Linux 6.12 driver interface. Use the dict-based channel-definition support merged in PR analogdevicesinc#780 directly to select voltage and temperature wrappers. Update CN0554 to select RX wrappers by channel name without redefining the base channel construction path. Signed-off-by: Mark Thoren <mark.thoren@analog.com> Signed-off-by: Travis F. Collins <travis.collins@analog.com>
tfcollins
force-pushed
the
ad7124_6.12_update
branch
from
July 16, 2026 00:13
5bb7e1a to
9f0f3d7
Compare
Contributor
Author
|
@tfcollins the dict-based channel-definition checks out, thanks! Ran the ad7125_example, cn0554_loopback, and the pytest fixture. Anything else to address? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the AD7124-8 class, examples, and dependent classes up-to-date with updated Linux driver, which in turn fixes a several bugs (like buffered channels becoming misaligned) and adds temperature sensor, calibration, and cleans up the filter type attributes.
Type of change
How has this been tested?
State explicitly whether this was tested against real hardware, an emulated context (iio-emu), or not run. Name the part(s) and the context URI or board used.
Hardware:
CN0554 (AD7124-8 and LTC2688) on Raspberry Pi 4
Commands run (e.g.
python3 -m pytest -k ad4080 --adi-hw-map):python -m pytest --color yes -vs test\test_ad7124_8.py --uri="ip:analog.local" --hw=ad7124-8
Result:
test/test_ad7124_8.py::test_ad7124_8_channels PASSED
test/test_ad7124_8.py::test_ad7124_8_rx_data[channel=[1, 2, 3, 4]-classname=adi.ad7124] PASSED
Emulation:
CI emulated hardware test
Result:
Passes
Test configuration
Documentation
doc/source/New device class interfaces
Skip this section if the PR does not add a new device class.
adi.device_base(rx_chan_comp,tx_chan_comp, or a_no_buffvariant). If not, explain why in the description. See the Device Base Classes developer doc page.compatible_partslists every part number this class supportssupported_parts.md(verify withinvoke checkparts)test/emu/and referenced from a testChecklist
invoke precommitpasses locallySigned-off-by: Name <email>)