Skip to content

arm/arm64: dts: adi: use ngpios DT property for port pin count #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiez wants to merge 2 commits into
base: adsp-6.18.31-y
Choose a base branch
from
Open

arm/arm64: dts: adi: use ngpios DT property for port pin count #3371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd51bb
arm/arm64: dts: adi: use ngpios DT property for port pin count
jiez May 20, 2026
53a4ea7
gpio: adi-adsp-port: remove hardcoded ADSP_PORT_NGPIO
jiez Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions arch/arm/boot/dts/adi/sc57x.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@
clock-output-names = "sys_clkin0";
};

sys_clkin1: sys-clkin1@2 {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <25000000>;
clock-output-names = "sys_clkin1";
};

Check warning on line 108 in arch/arm/boot/dts/adi/sc57x.dtsi

View workflow job for this annotation

GitHub Actions / build_gcc_arm / build 

(unit_address_vs_reg): /sys-clkin1@2: node has a unit name, but no reg or ranges property

clk: clocks@3108d000 {
compatible = "adi,sc57x-clocks";
Expand Down Expand Up @@ -214,11 +214,11 @@
#size-cells = <1>;
ranges;

pads_system_config: adi-control@31004400 {
compatible = "adi,pads-system-config";
reg = <0x31004400 0x100>;
status = "okay";
};

Check warning on line 221 in arch/arm/boot/dts/adi/sc57x.dtsi

View workflow job for this annotation

GitHub Actions / build_gcc_arm / build 

(unique_unit_address): /scb/adi-control@31004400: duplicate unit-address (also used in node /scb/pinctrl@31004400)

sram-controller@31080000 {
compatible = "adi,sram-controller";
Expand All @@ -228,11 +228,11 @@
status = "okay";
};

sram_mmap: sram-mmap@0 { /* mmap from sram1 pool*/
compatible = "adi,sram-mmap";
adi,sram = <&sram1>;
status = "disabled";
};

Check warning on line 235 in arch/arm/boot/dts/adi/sc57x.dtsi

View workflow job for this annotation

GitHub Actions / build_gcc_arm / build 

(simple_bus_reg): /scb/sram-mmap@0: missing or empty reg/ranges property

gptimer_counter: gptimer-counters@0 {
compatible = "adi,gptimer-counter";
Expand Down Expand Up @@ -560,6 +560,7 @@
#gpio-cells = <2>;
reg = <0x31004000 0x7F>;
gpio-ranges = <&pinctrl0 0 0 16>;
ngpios = <16>;
adi,pint = <&pint0 1>;
adi,gpio-base = <0>;
};
Expand All @@ -570,6 +571,7 @@
#gpio-cells = <2>;
reg = <0x31004080 0x7F>;
gpio-ranges = <&pinctrl0 0 16 16>;
ngpios = <16>;
adi,pint = <&pint0 0>;
adi,gpio-base = <16>;
};
Expand All @@ -580,6 +582,7 @@
#gpio-cells = <2>;
reg = <0x31004100 0x7F>;
gpio-ranges = <&pinctrl0 0 32 16>;
ngpios = <16>;
adi,pint = <&pint2 1>;
adi,gpio-base = <32>;
};
Expand All @@ -590,6 +593,7 @@
#gpio-cells = <2>;
reg = <0x31004180 0x7F>;
gpio-ranges = <&pinctrl0 0 48 16>;
ngpios = <16>;
adi,pint = <&pint2 0>;
adi,gpio-base = <48>;
};
Expand All @@ -600,6 +604,7 @@
#gpio-cells = <2>;
reg = <0x31004200 0x7F>;
gpio-ranges = <&pinctrl0 0 64 16>;
ngpios = <16>;
adi,pint = <&pint4 1>;
adi,gpio-base = <64>;
};
Expand All @@ -610,6 +615,7 @@
#gpio-cells = <2>;
reg = <0x31004280 0x7F>;
gpio-ranges = <&pinctrl0 0 80 12>;
ngpios = <12>;
adi,pint = <&pint4 0>;
adi,gpio-base = <80>;
};
Expand Down
7 changes: 7 additions & 0 deletions arch/arm/boot/dts/adi/sc58x.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,7 @@
#gpio-cells = <2>;
reg = <0x31004000 0x7F>;
gpio-ranges = <&pinctrl0 0 0 16>;
ngpios = <16>;
adi,pint = <&pint0 1>;
adi,gpio-base = <0>;
};
Expand All @@ -613,6 +614,7 @@
#gpio-cells = <2>;
reg = <0x31004080 0x7F>;
gpio-ranges = <&pinctrl0 0 16 16>;
ngpios = <16>;
adi,pint = <&pint0 0>;
adi,gpio-base = <16>;
};
Expand All @@ -623,6 +625,7 @@
#gpio-cells = <2>;
reg = <0x31004100 0x7F>;
gpio-ranges = <&pinctrl0 0 32 16>;
ngpios = <16>;
adi,pint = <&pint2 1>;
adi,gpio-base = <32>;
};
Expand All @@ -633,6 +636,7 @@
#gpio-cells = <2>;
reg = <0x31004180 0x7F>;
gpio-ranges = <&pinctrl0 0 48 16>;
ngpios = <16>;
adi,pint = <&pint2 0>;
adi,gpio-base = <48>;
};
Expand All @@ -643,6 +647,7 @@
#gpio-cells = <2>;
reg = <0x31004200 0x7F>;
gpio-ranges = <&pinctrl0 0 64 16>;
ngpios = <16>;
adi,pint = <&pint4 1>;
adi,gpio-base = <64>;
};
Expand All @@ -653,6 +658,7 @@
#gpio-cells = <2>;
reg = <0x31004280 0x7F>;
gpio-ranges = <&pinctrl0 0 80 16>;
ngpios = <16>;
adi,pint = <&pint4 0>;
adi,gpio-base = <80>;
};
Expand All @@ -663,6 +669,7 @@
#gpio-cells = <2>;
reg = <0x31004300 0x7F>;
gpio-ranges = <&pinctrl0 0 96 6>;
ngpios = <6>;
adi,pint = <&pint5 0>;
adi,gpio-base = <96>;
};
Expand Down
9 changes: 9 additions & 0 deletions arch/arm/boot/dts/adi/sc59x.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,7 @@
#gpio-cells = <2>;
reg = <0x31004000 0x7F>;
gpio-ranges = <&pinctrl0 0 0 16>;
ngpios = <16>;
adi,pint = <&pint0 1>;
adi,gpio-base = <0>;
};
Expand All @@ -649,6 +650,7 @@
#gpio-cells = <2>;
reg = <0x31004080 0x7F>;
gpio-ranges = <&pinctrl0 0 16 16>;
ngpios = <16>;
adi,pint = <&pint0 0>;
adi,gpio-base = <16>;
};
Expand All @@ -659,6 +661,7 @@
#gpio-cells = <2>;
reg = <0x31004100 0x7F>;
gpio-ranges = <&pinctrl0 0 32 16>;
ngpios = <16>;
adi,pint = <&pint2 1>;
adi,gpio-base = <32>;
};
Expand All @@ -669,6 +672,7 @@
#gpio-cells = <2>;
reg = <0x31004180 0x7F>;
gpio-ranges = <&pinctrl0 0 48 16>;
ngpios = <16>;
adi,pint = <&pint2 0>;
adi,gpio-base = <48>;
};
Expand All @@ -679,6 +683,7 @@
#gpio-cells = <2>;
reg = <0x31004200 0x7F>;
gpio-ranges = <&pinctrl0 0 64 16>;
ngpios = <16>;
adi,pint = <&pint4 1>;
adi,gpio-base = <64>;
};
Expand All @@ -689,6 +694,7 @@
#gpio-cells = <2>;
reg = <0x31004280 0x7F>;
gpio-ranges = <&pinctrl0 0 80 16>;
ngpios = <16>;
adi,pint = <&pint4 0>;
adi,gpio-base = <80>;
};
Expand All @@ -699,6 +705,7 @@
#gpio-cells = <2>;
reg = <0x31004300 0x7F>;
gpio-ranges = <&pinctrl0 0 96 16>;
ngpios = <16>;
adi,pint = <&pint6 1>;
adi,gpio-base = <96>;
};
Expand All @@ -709,6 +716,7 @@
#gpio-cells = <2>;
reg = <0x31004380 0x7F>;
gpio-ranges = <&pinctrl0 0 112 16>;
ngpios = <16>;
adi,pint = <&pint6 0>;
adi,gpio-base = <112>;
};
Expand All @@ -719,6 +727,7 @@
#gpio-cells = <2>;
reg = <0x31004400 0x7F>;
gpio-ranges = <&pinctrl0 0 128 7>;
ngpios = <7>;
adi,pint = <&pint7 1>;
adi,gpio-base = <128>;
};
Expand Down
9 changes: 9 additions & 0 deletions arch/arm64/boot/dts/adi/sc59x-64.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,7 @@
#gpio-cells = <2>;
reg = <0x31004000 0x7F>;
gpio-ranges = <&pinctrl0 0 0 16>;
ngpios = <16>;
adi,pint = <&pint0 1>;
status = "okay";
};
Expand All @@ -730,6 +731,7 @@
#gpio-cells = <2>;
reg = <0x31004080 0x7F>;
gpio-ranges = <&pinctrl0 0 16 16>;
ngpios = <16>;
adi,pint = <&pint0 0>;
status = "okay";
};
Expand All @@ -740,6 +742,7 @@
#gpio-cells = <2>;
reg = <0x31004100 0x7F>;
gpio-ranges = <&pinctrl0 0 32 16>;
ngpios = <16>;
adi,pint = <&pint2 1>;
status = "okay";
};
Expand All @@ -750,6 +753,7 @@
#gpio-cells = <2>;
reg = <0x31004180 0x7F>;
gpio-ranges = <&pinctrl0 0 48 16>;
ngpios = <16>;
adi,pint = <&pint2 0>;
};

Expand All @@ -759,6 +763,7 @@
#gpio-cells = <2>;
reg = <0x31004200 0x7F>;
gpio-ranges = <&pinctrl0 0 64 16>;
ngpios = <16>;
adi,pint = <&pint4 1>;
};

Expand All @@ -768,6 +773,7 @@
#gpio-cells = <2>;
reg = <0x31004280 0x7F>;
gpio-ranges = <&pinctrl0 0 80 16>;
ngpios = <16>;
adi,pint = <&pint4 0>;
};

Expand All @@ -777,6 +783,7 @@
#gpio-cells = <2>;
reg = <0x31004300 0x7F>;
gpio-ranges = <&pinctrl0 0 96 16>;
ngpios = <16>;
adi,pint = <&pint6 1>;
};

Expand All @@ -786,6 +793,7 @@
#gpio-cells = <2>;
reg = <0x31004380 0x7F>;
gpio-ranges = <&pinctrl0 0 112 16>;
ngpios = <16>;
adi,pint = <&pint6 0>;
};

Expand All @@ -795,6 +803,7 @@
#gpio-cells = <2>;
reg = <0x31004400 0x7F>;
gpio-ranges = <&pinctrl0 0 128 7>;
ngpios = <7>;
adi,pint = <&pint7 1>;
};

Expand Down
1 change: 0 additions & 1 deletion drivers/gpio/gpio-adi-adsp-port.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ static int adsp_gpio_probe(struct platform_device *pdev)
gpio->gpio.to_irq = adsp_gpio_to_irq;
gpio->gpio.request = gpiochip_generic_request;
gpio->gpio.free = gpiochip_generic_free;
gpio->gpio.ngpio = ADSP_PORT_NGPIO;
gpio->gpio.parent = dev;
gpio->gpio.base = -1;
ret = devm_gpiochip_add_data(dev, &gpio->gpio, gpio);
Expand Down
2 changes: 0 additions & 2 deletions include/linux/soc/adi/adsp-gpio-port.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

#include <linux/gpio/driver.h>

/* Number of GPIOs per port instance */
#define ADSP_PORT_NGPIO 16

/* PORT memory layout */
#define ADSP_PORT_REG_FER 0x00
Expand Down
Loading