[FREEZED Until V1 Migration is Done] Setup azure resource trigger - #39
[FREEZED Until V1 Migration is Done] Setup azure resource trigger#39liviutomoiaga wants to merge 2 commits into
Conversation
f993cdd to
ea3ce96
Compare
ea3ce96 to
bf55665
Compare
| strategy: | ||
| matrix: | ||
| ubuntu_20_04_x86_64: | ||
| image: 'tfcollins/libiio_ubuntu_20_04-ci:latest' |
There was a problem hiding this comment.
Doesn't this container (tfcollins/libiio_ubuntu_20_04-ci:latest) already have installed libiio? If not, what does it contain extra compared with ubuntu-latest ?
There was a problem hiding this comment.
It doesn't have libiio installed, because we install the latest version of libiio to check compatibility.
I has the libiio and libad9166/libad9163 dependencies already installed, which are not found in the ubuntu image
| ls -al | ||
| cd dist | ||
| ls -al |
There was a problem hiding this comment.
Probably you'll want to remove these debug commands.
There was a problem hiding this comment.
This are not related with this PR, they appear as changes just because a indentation was added in order to separate them in two stages
| set -e | ||
| sudo apt-get update | ||
| sudo apt-get install -y gcc-arm-linux-gnueabihf libc6-dev-armhf-cross | ||
| sudo apt-get install -y g++-arm-linux-gnueabihf |
There was a problem hiding this comment.
Why do you need so many compilers: gcc-arm-linux-gnueabihf , g++-arm-linux-gnueabihf , g++-aarch64-linux-gnu ? Are you building with all ?
| displayName: "Setup" | ||
| - script: | | ||
| set -e | ||
| sudo docker run --platform "linux/$(arch)" --rm -t --privileged -e ARTIFACTNAME=$(artifactName) -v "$(Agent.BuildDirectory)/s":"/ci" -v "/usr/bin/qemu-$(arch)-static":"/usr/bin/qemu-$(arch)-static" "$(image)" /bin/bash -c "cd /ci/ && chmod +x ./CI/travis/$(build_script) && ./CI/travis/$(build_script)" |
There was a problem hiding this comment.
I suppose we can push execution rights to the repo, so we won't need to change it every time. Please check if something like next script is possible:
git add ci-ubuntu.sh
git commit -m "ci-ubuntu.sh: make script executable"
git push```
If it works, it can be applied to all scripts from `CI/travis` folder.
| macOS_15_x64: | ||
| poolName: 'Azure Pipelines' | ||
| vmImage: 'macOS-15' | ||
| agentName: 'Azure Pipelines 11' |
There was a problem hiding this comment.
Please document the 'magic numbers' (in this example 11, 3, 2 ... ).
A comment with a short explanation is enough.
There was a problem hiding this comment.
Because we use a hosted agent for two other builds, an agent name had to specified for the other two also, and Azure Pipelines 11 is the name of the cloud agent from Azure
| echo "Owner=$OWNER" | ||
| echo "Repo=$REPO" |
There was a problem hiding this comment.
Are these echo's really necessary? or they were used for debugging and can be deleted?
There was a problem hiding this comment.
Those were used for debug purpose. Those 2 echos are removed now
586e1f2 to
9564b31
Compare
…tion stage Signed-off-by: Liviu Tomoiaga <Liviu.Tomoiaga@analog.com>
9564b31 to
740035f
Compare
|
For some of the comments a new PR should be opened, that focuses on refactoring |
liviutomoiaga
changed the title
3 participants
PR Description
This PR updates the CI/CD flow to introduce pipeline dependency management between libiio and libad9166.
Details:
Workflow
NOTE: To enable communication of the libad build status to the upper build layer (libiio), the token must include the following permission:
PR Type
PR Checklist