Update ad9166 test - #36
Open
trishaange01 wants to merge 1 commit into
Open
Conversation
SRaus
reviewed
Aug 1, 2024
SRaus
left a comment
SRaus
left a comment
Contributor
There was a problem hiding this comment.
Please add a commit description.
This change fixes the error caused by setting frequency to any value close to 3000000000 or higher
trishaange01
force-pushed
the
ad9166_test
branch
from
August 2, 2024 06:59
37613ae to
82f10c6
Compare
Collaborator
Author
Hi @SRaus. I already added a commit description and changed the commit message. :) |
SRaus
approved these changes
Aug 21, 2024
Contributor
|
@trishaange01 are there more details about this change? Why value 3000000 is not considered a valid input? |
Contributor
|
@trishaange01 @SRaus do you know if this PR still required? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This change includes an update on the frequency value being set by the set_frequency() function. The fix was made due to the issue produced by the previous value, 3000000000, which is "No such device" error. Also, any value close to 3000000000 and higher causes this error. The value being set now is 2100000000.
PR Type
PR Checklist