Update scripts to follow HDL main branch - #137
Open
StancaPop wants to merge 5 commits into
Open
Conversation
tfcollins
reviewed
Aug 23, 2023
tfcollins
reviewed
Aug 23, 2023
tfcollins
reviewed
Aug 23, 2023
tfcollins
requested changes
Aug 23, 2023
tfcollins
left a comment
tfcollins
left a comment
Collaborator
There was a problem hiding this comment.
Need to rebase this on master first.
Main question, can we remove CI/scripts/adi_project.tcl and just use what in the HDL repo?
StancaPop
force-pushed
the
update_scripts_for_master_hdl
branch
2 times, most recently
from
September 4, 2023 09:27
c7c2c08 to
3798893
Compare
StancaPop
force-pushed
the
update_scripts_for_master_hdl
branch
from
October 4, 2023 07:38
0125c25 to
7f011d1
Compare
Collaborator
Author
|
V2: The vivado version has been made parametrizable and set to 2022.2. The duplicate scripts copied from the hdl repo (adi_project_xilinx.tcl, adi_ip.tcl and adi_project.tcl) have been deleted and the scripts that use them have been modified to use the ones from the HDL repo. The modifications have been tested locally, using both the HWA and the test_synth method and they both passed. |
tfcollins
reviewed
Nov 27, 2023
tfcollins
reviewed
Nov 27, 2023
StancaPop
force-pushed
the
update_scripts_for_master_hdl
branch
from
December 6, 2023 08:42
529be4c to
5200974
Compare
StancaPop
force-pushed
the
update_scripts_for_master_hdl
branch
from
January 23, 2024 11:44
4f06480 to
16a8391
Compare
StancaPop
changed the title
tfcollins
reviewed
Jun 27, 2024
| properties(Constant) | ||
| HDL = 'hdl_2021_r2'; | ||
| Vivado = '2021.2'; | ||
| Vivado = '2023.1'; |
Collaborator
There was a problem hiding this comment.
We probably need to set this in a more programmatic way. So it just updates to whatever the HDL needs
The following changes have been made:
Add separate Jenkins file for hdl master branch
Add VIVADOVERSION parameter
Remove duplicates of HDL scripts:
adi_project_xilinx.tcl
adi_ip.tcl
adi_project.tcl
synth_designs.sh: Add root repo path
Replace "master" with "main" for HDL repo
StancaPop
force-pushed
the
update_scripts_for_master_hdl
branch
from
October 14, 2024 08:49
16a8391 to
c6fc949
Compare
Signed-off-by: Travis F. Collins <travis.collins@analog.com>
StancaPop
force-pushed
the
update_scripts_for_master_hdl
branch
from
October 14, 2024 08:55
c6fc949 to
4954320
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update has been tested with the adi_project_xilinx.tcl file from the HDL repo that contains the Matlab related environment variables ADI_MATLAB and ADI_SKIP_SYNTHESIS. This commit can be used along with the master branch from the HDL repo, as it also contains all the updates since the HDL_2021_R1 release has been made.
It has been tested both locally and on Jenkins.