fix(#24): correct ADBC transport CA-pinning claim in README - #25
Open
Analitiq-Bot wants to merge 2 commits into
Open
fix(#24): correct ADBC transport CA-pinning claim in README#25Analitiq-Bot wants to merge 2 commits into
Analitiq-Bot wants to merge 2 commits into
Conversation
README.md stated "Both transports receive the SSL mode and the CA certificate." which is false: the CA certificate is applied only on the sqlalchemy transport. Under ADBC the libpq driver rejects every adbc.postgresql.* option with NOT_IMPLEMENTED, and sslrootcert expects a filesystem path that a stored PEM secret cannot supply. Replace the inaccurate sentence with an accurate description of the per-transport TLS split, and add a matching entry to the Limitations section so the constraint is discoverable without reading the upgrade notes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The 2.0.0 upgrade section repeated the full CA-pinning explanation verbatim. The Transports section (line 89) and Limitations section (line 124) now carry it, so trim the upgrade note to a cross-reference pointer to eliminate the maintenance triple. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Analitiq-Bot
marked this pull request as ready for review
August 2, 2026 11:51
Collaborator
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.mdincorrectly stated "Both transports receive the SSL mode and the CA certificate." This was false: thessl_ca_certificateis applied only on thesqlalchemytransport. The ADBC transport cannot use the stored PEM secret for CA pinning — the libpq ADBC driver rejects everyadbc.postgresql.*database option withNOT_IMPLEMENTED, and libpq'ssslrootcertexpects a filesystem path, not PEM text. Under ADBC,verify-ca/verify-fullfall back to libpq's default CA lookup at~/.postgresql/root.crt.Changes:
No code changes; the accurate description has always been present in
AGENTS.md,CLAUDE.md(lines 44-48), and the upgrade notes — only the Transports narrative in the README contradicted it.Test plan
AGENTS.mdand theCLAUDE.mddescription of the two transports for consistency.Closes #24