Skip to content

fix bug image not deleted when update the cover or delete the book #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NeyShiKu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix bug image not deleted when update the cover or delete the book #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion core/repositories/MySQLBookRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,17 @@ public function save(Book $book): bool

public function update(int $id, Book $book): bool
{
$check = $this->pdo->prepare("SELECT cover_filename FROM books WHERE id = ?");
$check->execute([$id]);
$result = $check->fetch(PDO::FETCH_ASSOC);

$oldCover = $result['cover_filename'];

$stmt = $this->pdo->prepare(
"UPDATE books SET code = ?, title = ?, author = ?, publisher = ?, stock = ?, cover_filename = ?
WHERE id = ?"
);
return $stmt->execute([
$success = $stmt->execute([
$book->code,
$book->title,
$book->author,
Expand All @@ -59,10 +65,28 @@ public function update(int $id, Book $book): bool
$book->cover_filename,
$id
]);

if ($success && !is_null($oldCover)) {
$coverPath = __DIR__ . "/../../public/uploads/" . $oldCover;
if (file_exists($coverPath)) {
unlink($coverPath);
}
}

return $success;
}

public function delete(int $id): bool
{
$cover = $this->pdo->prepare("SELECT cover_filename FROM books WHERE id = ?");
$cover->execute([$id]);
$coverResult = $cover->fetch(PDO::FETCH_ASSOC);

if (!is_null($coverResult)) {
$coverPath = __DIR__ . "/../../public/uploads/" . $coverResult['cover_filename'];
unlink($coverPath);
}

$stmt = $this->pdo->prepare("DELETE FROM books WHERE id = ?");
return $stmt->execute([$id]);
}
Expand Down