docs(api): add missing periods to Destination name/type descriptions#366
Merged
Merged
Conversation
The Destination schema's 'id' description ends with a period but the sibling 'name' and 'type' descriptions did not. Add the missing periods for consistency. Regenerated api/generated/api.json to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Destinationschema'siddescription ends with a period, but the siblingnameandtypedescriptions did not. This adds the missing periods for consistency.api/api.yaml:nameandtypedescriptions (schema appears twice).api/generated/api.json: regenerated deref'd spec to match.Why now (testing the new automation)
This is also a live test of the openapi → amp-common Go-type automation. On merge, the
trigger-amp-common-genworkflow fires arepository_dispatchat amp-common, which regeneratesopenapi/api.gen.go. These descriptions surface as Go doc comments, so the auto-PR will contain exactly this 4-line change:(×2 — the schema is generated in two places.)
🤖 Generated with Claude Code