Skip to content

Iterable support#59

Open
guility wants to merge 3 commits into
amirziai:masterfrom
guility:patch-1
Open

Iterable support#59
guility wants to merge 3 commits into
amirziai:masterfrom
guility:patch-1

Conversation

@guility

@guility guility commented Oct 9, 2019

Copy link
Copy Markdown

Checks object part is Iterable not (tuple, list, set)

Allows to use deal with numpy.arrays and subclasses inside the dictionaries.

Checks object part is Iterable not (tuple, list, set)
@amirziai

Copy link
Copy Markdown
Owner

thanks for contributing @guility . can you add a test that shows how not having this causes problems?

@pep8speaks

pep8speaks commented Oct 22, 2019

Copy link
Copy Markdown

Hello @guility! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2186:1: W293 blank line contains whitespace

Comment last updated at 2019-10-22 16:49:27 UTC

@guility

guility commented Oct 22, 2019

Copy link
Copy Markdown
Author

@amirziai basically, if applying only to .jsons - there would be no such a problem.
BTW, if you try using it with some basic dictionaries containing custom iterables or numpy.ndarrays(which caused me to contribute) - you would have an issue.

You could check the test case in my latest commit to test your code with custom iterable.

@amirziai

amirziai commented Oct 22, 2019

Copy link
Copy Markdown
Owner

That's a great test! Thanks! Do you mind fixing the PEP8 issue too? See the comment from @pep8speaks ☝️

@amirziai

amirziai commented Oct 22, 2019

Copy link
Copy Markdown
Owner

also your branch is behind master, please merge the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants