Skip to content

fix some keys will be ignored! #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sudor wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix some keys will be ignored! #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
918930e
fix some keys will be ignored!
sudor Sep 9, 2019
a25f4b0
Merge branch 'master' into master
amirziai Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flatten_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ def _unflatten(dic, keys, value):
list_keys = sorted(flat_dict.keys())
for i, item in enumerate(list_keys):
if i != len(list_keys) - 1:
if not list_keys[i + 1].startswith(list_keys[i]):
if not list_keys[i + 1].startswith(list_keys[i]+'.'):

@fsramalho fsramalho May 22, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only accounts when separator=.. I think it should be if not list_keys[i + 1].startswith(list_keys[i]+separator):

_unflatten(unflattened_dict, item.split(separator),
flat_dict[item])
else:
Expand Down