fix: add URL validation in icons.mjs - #203
Open
anupamme wants to merge 1 commit into
Open
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
src/second_sidebar/utils/icons.mjs.Vulnerability
V-002src/second_sidebar/utils/icons.mjs:35Description: The fetchIconURL function fetches URLs derived from user input without validation. This allows Server-Side Request Forgery (SSRF) attacks where an attacker can make the extension request internal network resources, cloud metadata endpoints, or other restricted URLs.
Evidence
Exploitation scenario: An attacker enters a malicious URL in the web panel URL field (e.g., http://169.254.169.254/latest/meta-data for AWS metadata, http://localhost:8080/admin for internal services).
Scanner confirmation: multi_agent_ai rule
V-002flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Changes
src/second_sidebar/utils/icons.mjsBehavior Preservation
The change is scoped to 1 file on the vulnerable path.
Automated security fix by OrbisAI Security