Keep web panels open after permission prompt actions - #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choosing Allow or Block in a web panel's permission prompt also closes the floating web panel when Always on top is disabled. Firefox removes the notification before the click reaches the outer window, so the detached button fails the DOM containment check and is treated as an outside click.
Identify panel chrome through the button's owner document, which remains available after removal. This keeps the web panel open after a permission action and preserves dismissal on ordinary outside clicks.
Related to #193. The original report of unresponsive permission buttons has not been reproduced; this PR addresses the confirmed panel-closing behavior.
Validation:
git diff --checkpass.