Fix link context menus and temporary panel behavior - #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right-clicking an empty page could show the sidebar link actions or leave an empty separator. Preview panels could also remain after closing because Firefox's hidden URL bar interrupted tab removal, and their buttons lost their colored background when Firefox renamed the attention color token.
This PR:
gContextMenu.onSaveableLink, ignores nested submenu events, and recomputes the native separator after updating visibility.XULElement.toggleHidden(force)and documents the link actions in the README.Validation:
npx eslint ., Prettier on all changed files, andgit diff --check origin/master...HEADpassed.1328a90, before the finaltoggleHiddenhelper refactor.275c231was installed in the test profile and passed the normal Firefox startup check; all 150 deployed source files matched the commit.