Fix web panel badge initialization before native rendering - #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web panel buttons can exist before Firefox renders their internal badge stack, particularly when a saved button has no toolbar placement or belongs to an unopened popup. Initializing the sound and notification icons at that point throws
badgeStackXUL is nulland leaves them unattached.Wait for the native badge stack with a one-shot
MutationObserver, and use the same readiness helper when applying container colors. Cancel pending readiness timers and observers when a widget is removed or its window closes.Validation:
git diff --checkpass.