Add an option to disable window dragging from the sidebar - #197
Merged
Conversation
Allow users to disable window movement and double-click maximize/restore on empty sidebar space. Preserve the existing behavior by default and persist the setting across windows and restarts. Fixes #188
|
Beast mode! Thank you legend! |
Owner
Author
|
Sorry for waiting so long! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging or double-clicking empty sidebar space can accidentally move or restore a maximized Firefox window. Add an Allow window dragging setting that disables those actions through Firefox's native
nowindowdragtoolbar attribute.The setting defaults to enabled for existing profiles, applies immediately across browser windows, is restored by Cancel, and persists with Save. The README lists the new setting.
Fixes #188.
Validation
git diff --checkpass.customizingattribute, and persistence after restart. Original settings were restored after testing; no FSS errors were recorded.src/second_sidebar/css/customization.mjsandsrc/second_sidebar/css/sidebar_box.mjs; neither file is changed here.