Add support for multiple domain names - #12
Open
lightmaster wants to merge 1 commit into
Open
Conversation
TESTING: Tested with both a single and 2 domains when using cloudflare DNS. Should work for all providers that `lego` supports. Add `parse_domain_names()` function to convert a string of comma separated domains (or a single domain) into 2 variables, one containing original domains and one containing wildcard domains. Change `certFileName` to use the first value of the `DOMAIN_ARRAY` to prevent it from breaking saving the cert and key files Change `run_lego()` function to use the comma separated strings created in `parse_domain_names()` function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #11
TESTING: Tested with both a single and 2 domains when using cloudflare DNS. Should work for all providers that
legosupports.Add
parse_domain_names()function to convert a string of comma separated domains (or a single domain) into 2 variables, one containing original domains and one containing wildcard domains.Change
certFileNameto use the first value of theDOMAIN_ARRAYto prevent it from breaking saving the cert and key filesChange
run_lego()function to use the comma separated strings created inparse_domain_names()function