Ensure upstream is closed properly in main function#87
Open
maederm wants to merge 1 commit into
Open
Conversation
68020b0 to
b95db79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dnslookup doesn't close the upstream handle. This can lead to ICMP port unreachable errors from client to server.
I assume that dnslookup already exits before the quic sessions is terminated. The server then wants to close the connection and because the socket is already closed the kernel sends the ICMP unreachables.
After ensuring that dnslookup closes the handle before it exits I only rarely see ICMP unreachables.
Reproducer
The ICMP unreachables can reproduced with these commands:
sudo tcpdump -i {outgoing interface} -np host 9.9.9.9 dnslookup example.com quic://9.9.9.9Without the patch I see these in tcpdump: