Skip to content

Preserve original start and end times when copying runs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyler-richardett wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve original start and end times when copying runs #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mlflow_export_import/run/copy_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@ def copy_run(self, src_run_id, dst_exp_name):

def _copy_run(self, src_run_id, dst_experiment_id):
src_run = self.src_client.get_run(src_run_id)
dst_run = self.dst_client.create_run(dst_experiment_id) # NOTE: does not set user_id; is 'unknown'
dst_run = self.dst_client.create_run(experiment_id=dst_experiment_id, start_time=src_run.info.start_time) # NOTE: does not set user_id; is 'unknown'
self._copy_run_data(src_run, dst_run.info.run_id)
local_path = self.src_client.download_artifacts(src_run_id,"")
self.dst_client.log_artifacts(dst_run.info.run_id,local_path)
self.dst_client.set_terminated(dst_run.info.run_id, src_run.info.status)
self._update_run_info(src_run, dst_run)
return (dst_run.info.run_id, src_run.data.tags.get("mlflow.parentRunId",None))

def _copy_run_data(self, src_run, dst_run_id):
Expand All @@ -43,6 +44,9 @@ def _copy_run_data(self, src_run, dst_run_id):
utils.set_dst_user_id(tags, src_run.info.user_id, self.use_src_user_id)
self.dst_client.log_batch(dst_run_id, metrics, params, tags)

def _update_run_info(self, src_run, dst_run):
self.dst_client._tracking_client.store.update_run_info(run_id=dst_run.info.run_id, run_status=src_run.info.status, end_time=src_run.info.end_time)

@click.command()
@click.option("--src-uri", help="Source MLflow API URI.", required=True, type=str)
@click.option("--dst-uri", help="Destination MLflow API URI.", required=True, type=str)
Expand Down