[ROCm][CI] Validate shared ROCm SO file list#5
Draft
amdfaa wants to merge 8666 commits into
Draft
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER
Adds lightweight validation for the shared ROCm shared-library list introduced by the selected shared
.sobranch, plus focused tests that verify the list invariants, fail-fast validation behavior, and.ci/manywheel/repair_wheel.py's path-based loader behavior.Validation performed:
torch/_rocm_libs.pyand.ci/manywheel/repair_wheel.pypassed, including positive and negative validation cases.pythonwas unavailable andPYTHONPATH=/workspace python3 test/test_rocm_libs.py TestRocmLibs.test_rocm_so_files_are_valid_basenamescould not run because this unbuilt checkout lacks generatedtorch.version.Authored with Claude.