Skip to content

Haoyang Ding's codeReview #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KKDJOSEPH wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Haoyang Ding's codeReview #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions public/javascripts/genre.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
/*
* Haoyang Ding => Nabil:
*
* Your code style is great. I need to learn how you name variables and functions
* It seems that you write a lot of code, the 'windows.location' things. Actually I think a relative url will work.
* But since I don't have your db url, I can't try it on your project.
* And for the space issue, you want to change it to %20. There are several methods called escape(), encodeURI(), encodeURIComponent()
* Maybe these functions would help.
*
* */


let reviewsContainer = document.querySelector("#reviewsContainer");
let genreTitle = document.querySelector("#genreTitle");
let imageObject = {
Expand Down