Make XGBoost evaluation configurable - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
src.xgb_evalpreviously executed on import and used hard-coded Windows paths. The documented synthetic workflow could build features but could not run the XGBoost comparison with those sample paths, and the evaluator could not be safely reused in tests or other code.Impact
The original defaults remain available, while users can now evaluate any compatible feature CSV and choose output locations and evaluation settings. The workflow also reports a zero-error baseline as an undefined improvement instead of failing.
Validation
python -m pytest -q— 63 passeduvx --from ruff==0.16.0 ruff check src tests streamlit_app.py— passedpython -m compileall -q src tests streamlit_app.py— passed