Skip to content

fix(client): use GitPullRequest icon, not Github - #12

Open
keithpk wants to merge 2 commits into
alysnnix:mainfrom
keithpk:fix/unknown-github-icon
Open

keithpk wants to merge 2 commits into
alysnnix:mainfrom
keithpk:fix/unknown-github-icon

Conversation

@keithpk

@keithpk keithpk commented Oct 12, 2026 •

Copy link
Copy Markdown

fix(client): use GitPullRequest icon, not Github

Fixes #11

What fails. On Paseo 0.11.2 the plugin's server side starts, but the client fails to load: Settings → Plugins shows it as "failed" with Unknown Lucide icon: Github, and no sidebar item, command-center entry or settings screen appears.

Cause. index.client.tsx passes icon: "Github" in three registrations (the sidebar item, the settings screen and the command-center item open-board). The icon set in Paseo 0.11.2 does not include Github, so the host rejects the name and the whole client registration fails.

Fix. Two commits, no other change:

  • index.client.tsx: the three registrations now use GitPullRequest, an icon the host has.
  • client/timeline.tsx: the one other use of the same name, <Icon name="Github" … /> in the timeline card header, now uses GitPullRequest by the same rule, so the plugin names no icon the host lacks. A search of the client (icon: values and <Icon name=…>) found no other Github.

Verified.

  • On Paseo 0.11.2, with the three registrations renamed in an installed copy and the plugin reloaded, the client loads and the plugin's GitHub sidebar entry appears (confirmed by the reporter of Client fails to load on Paseo 0.11.2: "Unknown Lucide icon: Github" #11).
  • On this branch: npm run typecheck, npm run lint and npm test (55 tests) pass. The lint run prints two existing complexity warnings in scripts/lib/scan.mjs, untouched here.

Not verified.

  • The timeline card change: it follows the same rule as the three registrations but was not checked at runtime on 0.11.2.
  • Anything beyond the sidebar entry appearing: the board itself, the settings screen and the command-center item were not exercised. There is no UI harness.
  • Other Paseo versions: I do not know which hosts have GitPullRequest besides 0.11.2.

Suggestion, not changed here. The plugin depends on @getpaseo/plugin 0.8.0-beta.1; raising it to a current version would let icon names be checked against a current host.

🤖 Generated with Claude Code

keithpk and others added 2 commits October 12, 2026 11:46
- Paseo 0.11.2's icon set has no "Github", so the host rejects the name
  and the whole client registration fails ("Unknown Lucide icon: Github").
- Rename the three registrations in index.client.tsx (sidebar item,
  settings screen, command-center item) to "GitPullRequest".

Fixes alysnnix#11

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- The timeline card header rendered <Icon name="Github" />, the same
  name Paseo 0.11.2's icon set lacks; use GitPullRequest as in the
  three registrations, so the plugin names no icon the host lacks.

Refs alysnnix#11

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@keithpk
keithpk force-pushed the fix/unknown-github-icon branch from 02546ea to b5d0a50 Compare October 12, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client fails to load on Paseo 0.11.2: "Unknown Lucide icon: Github"

1 participant