Repository navigation
Conversation
- Paseo 0.11.2's icon set has no "Github", so the host rejects the name
and the whole client registration fails ("Unknown Lucide icon: Github").
- Rename the three registrations in index.client.tsx (sidebar item,
settings screen, command-center item) to "GitPullRequest".
Fixes alysnnix#11
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- The timeline card header rendered <Icon name="Github" />, the same name Paseo 0.11.2's icon set lacks; use GitPullRequest as in the three registrations, so the plugin names no icon the host lacks. Refs alysnnix#11 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
keithpk
force-pushed
the
fix/unknown-github-icon
branch
from
October 12, 2026 18:56
02546ea to
b5d0a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(client): use GitPullRequest icon, not Github
Fixes #11
What fails. On Paseo 0.11.2 the plugin's server side starts, but the client fails to load: Settings → Plugins shows it as "failed" with
Unknown Lucide icon: Github, and no sidebar item, command-center entry or settings screen appears.Cause.
index.client.tsxpassesicon: "Github"in three registrations (the sidebar item, the settings screen and the command-center itemopen-board). The icon set in Paseo 0.11.2 does not includeGithub, so the host rejects the name and the whole client registration fails.Fix. Two commits, no other change:
index.client.tsx: the three registrations now useGitPullRequest, an icon the host has.client/timeline.tsx: the one other use of the same name,<Icon name="Github" … />in the timeline card header, now usesGitPullRequestby the same rule, so the plugin names no icon the host lacks. A search of the client (icon:values and<Icon name=…>) found no otherGithub.Verified.
npm run typecheck,npm run lintandnpm test(55 tests) pass. The lint run prints two existing complexity warnings inscripts/lib/scan.mjs, untouched here.Not verified.
GitPullRequestbesides 0.11.2.Suggestion, not changed here. The plugin depends on
@getpaseo/plugin0.8.0-beta.1; raising it to a current version would let icon names be checked against a current host.🤖 Generated with Claude Code