Skip to content

feat: ignore non-jira configurations#27

Merged
barredterra merged 6 commits into
alyf-de:version-15from
0xD0M1M0:disable_jira
Jun 29, 2026
Merged

feat: ignore non-jira configurations#27
barredterra merged 6 commits into
alyf-de:version-15from
0xD0M1M0:disable_jira

Conversation

@0xD0M1M0

Copy link
Copy Markdown
Contributor

This PR relaxes validations for projects without Jira sites. It will not block submit if a Jira key was entered, but no Jira site is linked. Also it will not prevent users to write internal notes if no Jira key is set.

@greptile-apps

greptile-apps Bot commented Jun 23, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

Safe to merge — both the get_jira_issue_url and get_description edge cases for missing jira_site are correctly guarded, the extracted billable_row_missing_invoice_reference helper covers all expected exemptions, and the refactored parse_note preserves previous behaviour for all note shapes.

All changed logic is thoroughly covered by new unit tests. The two code paths most likely to regress (URL generation and description formatting without a Jira site) are now explicitly guarded and tested. No functional regressions were found in validation, note parsing, or timesheet creation.

No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Working Time Log row] --> B{is_break?}
    B -->|yes| OK[No reference required]
    B -->|no| C{billable == 0% or no project?}
    C -->|yes| OK
    C -->|no| D{task set?}
    D -->|yes| OK
    D -->|no| E{key set?}
    E -->|yes| OK
    E -->|no| F{external note: starts with + AND 3+ chars after +?}
    F -->|yes| OK
    F -->|no| FAIL[ValidationError: add task, Jira key, or external note]

    subgraph get_description
        G[key + jira_site?] -->|yes| H[Fetch Jira summary]
        G -->|no, key only| I[Use key as description]
        G -->|neither| J[Use note or '-']
        H --> K{note set?}
        I --> K
        K -->|yes| L[Append note]
        K -->|no| M[Return description]
        L --> M
    end
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Working Time Log row] --> B{is_break?}
    B -->|yes| OK[No reference required]
    B -->|no| C{billable == 0% or no project?}
    C -->|yes| OK
    C -->|no| D{task set?}
    D -->|yes| OK
    D -->|no| E{key set?}
    E -->|yes| OK
    E -->|no| F{external note: starts with + AND 3+ chars after +?}
    F -->|yes| OK
    F -->|no| FAIL[ValidationError: add task, Jira key, or external note]

    subgraph get_description
        G[key + jira_site?] -->|yes| H[Fetch Jira summary]
        G -->|no, key only| I[Use key as description]
        G -->|neither| J[Use note or '-']
        H --> K{note set?}
        I --> K
        K -->|yes| L[Append note]
        K -->|no| M[Return description]
        L --> M
    end
Loading

Reviews (6): Last reviewed commit: "fix: remove internal note requirement" | Re-trigger Greptile

Comment thread working_time/working_time/doctype/working_time/test_working_time.py Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@barredterra
barredterra merged commit 15f0b67 into alyf-de:version-15 Jun 29, 2026
3 checks passed
@barredterra

Copy link
Copy Markdown
Member

🎉 This PR is included in version 15.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

barredterra pushed a commit to 0xD0M1M0/working_time that referenced this pull request Jun 29, 2026
# [15.6.0](alyf-de/working_time@v15.5.0...v15.6.0) (2026-06-29)

### Features

* ignore non-jira configurations ([alyf-de#27](alyf-de#27)) ([15f0b67](alyf-de@15f0b67))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants