fix(Employee): move Expected Daily Working Time to child table (DRC-148)#9
Merged
Conversation
Member
|
@PatrickDEissler shouldn't we merge this one instead? Because we already know that (average) "Expected Daily Working Time" doesn't reflect the reality in most companies. It is common to specify working time for each week day, i.e. in the DATEV's default employee survey:
Image source: https://www.steuerkanzlei-friedrich.de/data/DATEV-Personalbogen.pdf The weekdays you are working on is also relevant for knowing what day counts as vacation. |
PatrickDEissler
assigned
PatrickDEissler and
barredterra and unassigned
PatrickDEissler
barredterra
reviewed
Jun 13, 2025
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Expected Daily Time can change from time to time.
Currently the flexitime calculations relies on a static value (a float field). This can lead to data inconsistencies.
Solution
Use a child table, instead of a float field, that allows date-specific Expected Daily Time.
Follow Up
#8