feat: wrap each locale and pot file in its own details section#2
Merged
Conversation
Split oversized sections across comments instead of truncating, and keep packing small sections together when they fit.
Confidence Score: 5/5Safe to merge; the refactor correctly replaces truncation with proper per-locale splitting and all new code paths are covered by tests. The binary-search splitting logic is sound (monotonicity holds, conservative bounds prevent false fits, final sections are rebuilt with correct counts), packing is unchanged, and five new tests verify wrapping, packing, and splitting for both PO and POT paths. No dropped rows, no data loss, no silent truncation. No files require special attention. Reviews (2): Last reviewed commit: "fix: validate fast-path sections against..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split oversized sections across comments instead of truncating, and keep packing small sections together when they fit.