Skip to content

feat: wrap each locale and pot file in its own details section#2

Merged
barredterra merged 2 commits into
mainfrom
wrap-and-pack
Jul 19, 2026
Merged

feat: wrap each locale and pot file in its own details section#2
barredterra merged 2 commits into
mainfrom
wrap-and-pack

Conversation

@barredterra

@barredterra barredterra commented Jul 18, 2026

Copy link
Copy Markdown
Member

Split oversized sections across comments instead of truncating, and keep packing small sections together when they fit.

Split oversized sections across comments instead of truncating,
and keep packing small sections together when they fit.
@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

Safe to merge; the refactor correctly replaces truncation with proper per-locale splitting and all new code paths are covered by tests.

The binary-search splitting logic is sound (monotonicity holds, conservative bounds prevent false fits, final sections are rebuilt with correct counts), packing is unchanged, and five new tests verify wrapping, packing, and splitting for both PO and POT paths. No dropped rows, no data loss, no silent truncation.

No files require special attention.

Reviews (2): Last reviewed commit: "fix: validate fast-path sections against..." | Re-trigger Greptile

Comment thread po_pr_review.py
Comment thread po_pr_review.py
@barredterra
barredterra merged commit 34c28fd into main Jul 19, 2026
3 checks passed
@barredterra
barredterra deleted the wrap-and-pack branch July 19, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant