feat: Bank Reconciliation Rule Preview & Filter Preset (backport #366)#402
Conversation
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com> (cherry picked from commit 1eea476) # Conflicts: # banking/klarna_kosma_integration/doctype/bank_reconciliation_rule/test_bank_reconciliation_rule.py
This comment was marked as resolved.
This comment was marked as resolved.
Confidence Score: 5/5This is a well-isolated additive backport that does not modify existing validation or reconciliation logic. All new server-side code validates filters before they touch the DB, uses parameterized frappe.get_list, and gates access with has_permission. The JS layer escapes all dynamic content before DOM insertion and uses a request-ID pattern to discard stale async responses. The _create_account helper correctly handles both create and update paths, and integration tests cover the key edge cases. No files require special attention. Reviews (2): Last reviewed commit: "refactor: normalize bank reconciliation ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
barredterra
left a comment
barredterra
left a comment
There was a problem hiding this comment.
Tested, works as expected
|
🎉 This PR is included in version 16.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Proposed solution for #359
This is an automatic backport of pull request #366 done by Mergify.